-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KDoc for convoluted PathFilters.isIgnored #3312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3312 +/- ##
=========================================
Coverage 80.02% 80.02%
Complexity 2673 2673
=========================================
Files 443 443
Lines 8130 8130
Branches 1545 1545
=========================================
Hits 6506 6506
Misses 796 796
Partials 828 828
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! Thank you.
Could we also add this phenomenal comment to the test description in PathFiltersSpec.kt
? I think this will be beneficial for future readers of the code to have a test for each case.
Bonus (test) case: have the same path included as well as excluded
I added the test case as another form of documentation |
* Add KDoc for convoluted PathFilters.isIgnored * Add tests for convoluted PathFilters.isIgnored * Fix NoConsecutiveBlankLines * Fix conjugation in description
#3279 describes the scenario that rules are not doing anything if neither
includes
orexcludes
are specified.When reading the code, it comes to me that
PathFilters.isIgnored()
is a bit convoluted and probably the implementation is not working as expected. Therefore I publish this PR to describe the current behavior. And in case we update the behavior later, we should be able to correct the doc and help the reviewers to understand the status quo.