Fix reports not propagated to detekt task with type resolution - #3313
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3313 +/- ##
============================================
+ Coverage 80.03% 80.27% +0.23%
- Complexity 2669 2676 +7
============================================
Files 443 443
Lines 8140 8142 +2
Branches 1548 1548
============================================
+ Hits 6515 6536 +21
+ Misses 796 775 -21
- Partials 829 831 +2
Continue to review full report at Codecov.
|
schalkms
reviewed
Dec 22, 2020
schalkms
approved these changes
Dec 22, 2020
Member
Author
|
This PR is blocking me from testing the solution for #853. When possible, please merge this pull request. |
Member
|
@chao2zhang good to know. This PR will be merged asap if at least two maintainers review and approve it. Hence, I send out an review invitation. |
BraisGabin
approved these changes
Dec 23, 2020
BraisGabin
left a comment
Member
There was a problem hiding this comment.
Nice catch! And it's great to increase our test base 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuring detekt gradle extension as below does not actually generate SARIF reports when running
detekt<SourceSet>like:detektMain. The problem here is that we are merely not passing thereportsinDetektExtensiontoreportsofDetektas a gradle task.In addition to integration testing, I also manually verified through a sample project that the above is working.