Skip to content

Fix runLastOnRoot being empty in KtLintMultiRule - #3318

Merged
schalkms merged 2 commits into
detekt:masterfrom
picklebento:ktlintlint
Dec 24, 2020
Merged

Fix runLastOnRoot being empty in KtLintMultiRule#3318
schalkms merged 2 commits into
detekt:masterfrom
picklebento:ktlintlint

Conversation

@picklebento

Copy link
Copy Markdown
Member

RestrictToRootLast implements RestrictToRoot, so we need to check is RestrictToRootLast first.

Before
Before

After
After

@codecov

codecov Bot commented Dec 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3318 (28eab58) into master (c6a971f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3318      +/-   ##
============================================
+ Coverage     80.27%   80.31%   +0.03%     
- Complexity     2676     2711      +35     
============================================
  Files           443      443              
  Lines          8142     8142              
  Branches       1548     1548              
============================================
+ Hits           6536     6539       +3     
  Misses          775      775              
+ Partials        831      828       -3     
Impacted Files Coverage Δ Complexity Δ
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 96.92% <100.00%> (+4.61%) 11.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a971f...4eb3536. Read the comment docs.

@schalkms
schalkms merged commit 4ff6a22 into detekt:master Dec 24, 2020
@picklebento
picklebento deleted the ktlintlint branch December 24, 2020 17:40
@BraisGabin BraisGabin added this to the 1.16.0 milestone Dec 27, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* Fix `runLastOnRoot` being empty in KtLintMultiRule

* Update detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/KtLintMultiRuleSpec.kt

Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants