-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply binary compatibility plugin to Detekt #3320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
=========================================
Coverage 80.33% 80.33%
Complexity 2719 2719
=========================================
Files 445 445
Lines 8165 8165
Branches 1552 1552
=========================================
Hits 6559 6559
Misses 774 774
Partials 832 832 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻👏🏻👏🏻👏🏻
Is it possible to merge this PR already? The benefit of this PR overwhelms its temporary hack. |
* Apply binary compatibility plugin to Detekt * Exclude internal api * Add an additional new line * Fix comment to point out the problem in gradle setup * Remove TODO as forbidden comment
I can't remove the workaround after I merge #3322 🤔. The issue is still there. |
Let me open a new issue to further investigate. |
* Apply binary compatibility plugin to Detekt * Exclude internal api * Add an additional new line * Fix comment to point out the problem in gradle setup * Remove TODO as forbidden comment
This will help catch API changes like discussed in #3310 (comment)
There is also a temporary workaround to exclude rootProject from compability check. See Kotlin/binary-compatibility-validator#32
When running
./gradlew build
, if there is any change in :detekt-api, the task will fail with the following message