Apply binary compatibility plugin to Detekt - #3320
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
=========================================
Coverage 80.33% 80.33%
Complexity 2719 2719
=========================================
Files 445 445
Lines 8165 8165
Branches 1552 1552
=========================================
Hits 6559 6559
Misses 774 774
Partials 832 832 Continue to review full report at Codecov.
|
BraisGabin
reviewed
Dec 25, 2020
schalkms
approved these changes
Dec 26, 2020
This was referenced Dec 26, 2020
Merged
BraisGabin
approved these changes
Dec 28, 2020
Member
Author
|
Is it possible to merge this PR already? The benefit of this PR overwhelms its temporary hack. |
picklebento
pushed a commit
to picklebento/detekt
that referenced
this pull request
Dec 30, 2020
* Apply binary compatibility plugin to Detekt * Exclude internal api * Add an additional new line * Fix comment to point out the problem in gradle setup * Remove TODO as forbidden comment
Member
|
I can't remove the workaround after I merge #3322 🤔. The issue is still there. |
Member
Author
|
Let me open a new issue to further investigate. |
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Apply binary compatibility plugin to Detekt * Exclude internal api * Add an additional new line * Fix comment to point out the problem in gradle setup * Remove TODO as forbidden comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help catch API changes like discussed in #3310 (comment)
There is also a temporary workaround to exclude rootProject from compability check. See Kotlin/binary-compatibility-validator#32
When running
./gradlew build, if there is any change in :detekt-api, the task will fail with the following message