Skip to content

Conversation

@BraisGabin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3330 (d8c5b77) into master (9270ee6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3330   +/-   ##
=========================================
  Coverage     80.33%   80.33%           
  Complexity     2719     2719           
=========================================
  Files           445      445           
  Lines          8165     8165           
  Branches       1552     1552           
=========================================
  Hits           6559     6559           
  Misses          774      774           
  Partials        832      832           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9270ee6...d8c5b77. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask what’s the reason for the change?

@BraisGabin
Copy link
Member Author

There is not a real reason here. I was working on #3322 and I saw this. It's strange that the file that we crate with the version number depend on the OS of the person that runs it. Right?

I mean, if Artur moves from Unix to Windows or vice versa the file should not change it's end of line.

@schalkms schalkms merged commit 01e600e into detekt:master Jan 7, 2021
@BraisGabin BraisGabin deleted the versions-new-line branch January 7, 2021 13:58
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants