Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing website deployment on master #3332

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Dec 27, 2020

The reason was the following:
"Gemfile.lock It is likely that you need to grant write permissions for that path."
Consequently, write permission is given for the Gemfile.lock file.

Fixes #3321

The reason was the following:
"Gemfile.lock It is likely that you need to grant write permissions for that path."
Consequently, write permission is given for the Gemfile.lock file.

Fixes #3321
@schalkms schalkms force-pushed the schalkms-#3321-website-deployment branch from 97f040a to cd77b2b Compare December 27, 2020 23:16
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3332 (cd77b2b) into master (fb50099) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3332   +/-   ##
=========================================
  Coverage     80.32%   80.32%           
  Complexity     2721     2721           
=========================================
  Files           445      445           
  Lines          8168     8168           
  Branches       1553     1553           
=========================================
  Hits           6561     6561           
  Misses          774      774           
  Partials        833      833           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb50099...cd77b2b. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange, why did it work before 🤔?

@schalkms schalkms merged commit d768ea8 into master Dec 28, 2020
@schalkms schalkms deleted the schalkms-#3321-website-deployment branch December 28, 2020 10:39
@schalkms
Copy link
Member Author

Quite frankly, I don’t have a valid explanation here. However, I didn’t dig into it further being happy that it works™️ again.

chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request Dec 30, 2020
The reason was the following:
"Gemfile.lock It is likely that you need to grant write permissions for that path."
Consequently, write permission is given for the Gemfile.lock file.

Fixes detekt#3321
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
The reason was the following:
"Gemfile.lock It is likely that you need to grant write permissions for that path."
Consequently, write permission is given for the Gemfile.lock file.

Fixes #3321
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website deployment fails on master branch
3 participants