Refactor tests in detekt-gradle-plugin - #3333
Merged
Merged
Conversation
1. Moved data classes, DslGradleRunner, and DslTestBuilder under `testkit` 2. Updated because reason in build.gradle.kts 3. Inlined and updated the formatting version under test.
Codecov Report
@@ Coverage Diff @@
## master #3333 +/- ##
=========================================
Coverage 80.32% 80.32%
Complexity 2721 2721
=========================================
Files 445 445
Lines 8168 8168
Branches 1553 1553
=========================================
Hits 6561 6561
Misses 774 774
Partials 833 833 Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Dec 28, 2020
BraisGabin
left a comment
BraisGabin
left a comment
Member
There was a problem hiding this comment.
Nice!
It will help if, the next time, you move files in one commit and refactor the file in another. This way we can review it commit by commit and see the actual changes in that file. Otherwise git says "this file was removed and this other was added".
Don't change it now! There's no need.
BraisGabin
approved these changes
Dec 28, 2020
schalkms
approved these changes
Dec 28, 2020
picklebento
pushed a commit
to picklebento/detekt
that referenced
this pull request
Dec 30, 2020
* Refactor tests in detekt-gradle-plugin 1. Moved data classes, DslGradleRunner, and DslTestBuilder under `testkit` 2. Updated because reason in build.gradle.kts 3. Inlined and updated the formatting version under test. * Improve constraint message and reduce visibility * Use the code generated `DEFAULT_DETEKT_VERSION`
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Refactor tests in detekt-gradle-plugin 1. Moved data classes, DslGradleRunner, and DslTestBuilder under `testkit` 2. Updated because reason in build.gradle.kts 3. Inlined and updated the formatting version under test. * Improve constraint message and reduce visibility * Use the code generated `DEFAULT_DETEKT_VERSION`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testkit