-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recover binary compatibility with 1.15.0 #3336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3336 +/- ##
=========================================
Coverage 80.28% 80.29%
Complexity 2714 2714
=========================================
Files 445 445
Lines 8196 8195 -1
Branches 1558 1558
=========================================
Hits 6580 6580
+ Misses 778 777 -1
Partials 838 838
Continue to review full report at Codecov.
|
I removed that default implementation because the default implementation is self-recursive and no one should be using the buggy default implementation. If the goal is to ensure absolute binary compatibility, then this PR would make sense. |
On second thought, we could maintain the binary compatibility by implementing the function with an empty body.. |
I like that! Done. |
* recover binary compatibility with 1.15.0 * Remove recursive call
I move the project to 1.15.0 and runned the task
apiDump
and I found that we already had a binary compatibility problem. This code just restores that compatibility so 1.16.0 will be binary compatible with 1.15.0