Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover binary compatibility with 1.15.0 #3336

Merged
merged 2 commits into from
Jan 7, 2021
Merged

recover binary compatibility with 1.15.0 #3336

merged 2 commits into from
Jan 7, 2021

Conversation

BraisGabin
Copy link
Member

I move the project to 1.15.0 and runned the task apiDump and I found that we already had a binary compatibility problem. This code just restores that compatibility so 1.16.0 will be binary compatible with 1.15.0

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #3336 (2f57e07) into master (6b065a8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3336   +/-   ##
=========================================
  Coverage     80.28%   80.29%           
  Complexity     2714     2714           
=========================================
  Files           445      445           
  Lines          8196     8195    -1     
  Branches       1558     1558           
=========================================
  Hits           6580     6580           
+ Misses          778      777    -1     
  Partials        838      838           
Impacted Files Coverage Δ Complexity Δ
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt 70.00% <0.00%> (+6.36%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b065a8...fc6b41e. Read the comment docs.

@chao2zhang
Copy link
Member

I removed that default implementation because the default implementation is self-recursive and no one should be using the buggy default implementation.

If the goal is to ensure absolute binary compatibility, then this PR would make sense.

@chao2zhang
Copy link
Member

On second thought, we could maintain the binary compatibility by implementing the function with an empty body..

@BraisGabin
Copy link
Member Author

On second thought, we could maintain the binary compatibility by implementing the function with an empty body.

I like that! Done.

@schalkms schalkms merged commit a17e332 into detekt:master Jan 7, 2021
@BraisGabin BraisGabin deleted the recover-compatibility branch January 7, 2021 13:56
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* recover binary compatibility with 1.15.0

* Remove recursive call
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants