Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkNotNull #3352

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Remove checkNotNull #3352

merged 1 commit into from
Jan 7, 2021

Conversation

BraisGabin
Copy link
Member

Avoid the use of checkNotNull when it's not necessary.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #3352 (1e6a39d) into master (da372a7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3352      +/-   ##
============================================
+ Coverage     80.27%   80.31%   +0.03%     
  Complexity     2713     2713              
============================================
  Files           445      445              
  Lines          8194     8195       +1     
  Branches       1558     1558              
============================================
+ Hits           6578     6582       +4     
  Misses          778      778              
+ Partials        838      835       -3     
Impacted Files Coverage Δ Complexity Δ
...tlin/io/gitlab/arturbosch/detekt/cli/JCommander.kt 100.00% <100.00%> (+8.69%) 0.00 <0.00> (ø)
...osch/detekt/core/baseline/BaselineResultMapping.kt 78.57% <100.00%> (+7.14%) 6.00 <4.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da372a7...fd4f3fb. Read the comment docs.

@BraisGabin BraisGabin changed the title Remove an unnecessary checkNotNull Remove checkNotNull Jan 6, 2021
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schalkms schalkms merged commit 5f1c334 into detekt:master Jan 7, 2021
@BraisGabin BraisGabin deleted the simplify-code branch January 7, 2021 13:57
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants