Skip to content

Improve gradle plugin#3354

Merged
arturbosch merged 7 commits into
detekt:masterfrom
BraisGabin:improve-gradle-plugin
Jan 18, 2021
Merged

Improve gradle plugin#3354
arturbosch merged 7 commits into
detekt:masterfrom
BraisGabin:improve-gradle-plugin

Conversation

@BraisGabin

Copy link
Copy Markdown
Member

Align how we register all our tasks in our plugin.

And I renamed "oldDetekt" to "vanillaDetekt". The old is kind of missleading because is the only non-experimental way that we expose.

@codecov

codecov Bot commented Jan 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3354 (377bd70) into master (25edc90) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3354      +/-   ##
============================================
- Coverage     80.45%   80.43%   -0.02%     
- Complexity     2737     2740       +3     
============================================
  Files           447      448       +1     
  Lines          8287     8281       -6     
  Branches       1573     1573              
============================================
- Hits           6667     6661       -6     
  Misses          772      772              
  Partials        848      848              
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 27.95% <ø> (ø) 19.00 <0.00> (ø)
...gitlab/arturbosch/detekt/internal/DetektAndroid.kt 71.87% <ø> (ø) 12.00 <0.00> (ø)
.../io/gitlab/arturbosch/detekt/internal/DetektJvm.kt 59.25% <ø> (ø) 5.00 <0.00> (ø)
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt 87.50% <87.50%> (ø) 5.00 <5.00> (?)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 80.95% <100.00%> (-3.43%) 9.00 <1.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25edc90...c8b25d8. Read the comment docs.

@picklebento

Copy link
Copy Markdown
Member

What do you think about the name typeNotResolvedDetekt over vanillaDetekt?

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup :)

@cortinico

Copy link
Copy Markdown
Member

What do you think about the name typeNotResolvedDetekt over vanillaDetekt?

I'd be more for plainDetekt

@BraisGabin

Copy link
Copy Markdown
Member Author

Sorry for the delay, renamed to Plain.

@arturbosch arturbosch merged commit f9e3e41 into detekt:master Jan 18, 2021
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
@BraisGabin BraisGabin deleted the improve-gradle-plugin branch January 18, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants