Suppress RedundantVisibilityModifierRule if explicit API mode enabled - #3358
Merged
schalkms merged 2 commits intoJan 10, 2021
Conversation
This solution uses the languageVersionSettings of the compiler to fetch the API mode setting. Explicit API mode was added in Kotlin 1.4 It prevents libraries' authors from making APIs public unintentionally. In this mode, the visibility modifier should be defined explicitly even if it is public. See: https://kotlinlang.org/docs/reference/whatsnew14.html#explicit-api-mode-for-library-authors Closes #3125
Codecov Report
@@ Coverage Diff @@
## master #3358 +/- ##
============================================
+ Coverage 80.27% 80.30% +0.02%
- Complexity 2713 2716 +3
============================================
Files 445 445
Lines 8194 8196 +2
Branches 1558 1559 +1
============================================
+ Hits 6578 6582 +4
Misses 778 778
+ Partials 838 836 -2
Continue to review full report at Codecov.
|
cortinico
approved these changes
Jan 10, 2021
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
…#3358) * Suppress RedundantVisibilityModifierRule if explicit API mode enabled This solution uses the languageVersionSettings of the compiler to fetch the API mode setting. Explicit API mode was added in Kotlin 1.4 It prevents libraries' authors from making APIs public unintentionally. In this mode, the visibility modifier should be defined explicitly even if it is public. See: https://kotlinlang.org/docs/reference/whatsnew14.html#explicit-api-mode-for-library-authors Closes #3125 * Declare variables in Spec as memoized
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution uses the languageVersionSettings of the compiler to fetch the API mode setting.
Explicit API mode was added in Kotlin 1.4
It prevents library authors from making APIs public unintentionally.
In this mode, the visibility modifier should be defined explicitly even if it is public.
See: https://kotlinlang.org/docs/reference/whatsnew14.html#explicit-api-mode-for-library-authors
Closes #3125