Fix maven publish#3392
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3392 +/- ##
=========================================
Coverage 80.40% 80.40%
Complexity 2745 2745
=========================================
Files 448 448
Lines 8279 8279
Branches 1582 1582
=========================================
Hits 6657 6657
Misses 767 767
Partials 855 855 Continue to review full report at Codecov.
|
cortinico
approved these changes
Jan 20, 2021
BraisGabin
approved these changes
Jan 20, 2021
schalkms
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The deployment task failed: https://github.com/detekt/detekt/runs/1730645753
This issue is also observed locally that after
./gradlew publishToMavenLocal, we should see a directory structure like.m2/repository/io/gitlab/arturbosch/detekt/detekt-*. However,.m2/repository/detekt/detekt-*was observed.Root cause
#3389 implicitly changed the order of
commons.gradle.ktsto rootbuild.gradle)packaging.gradle.kts)Switching the order resulted in incorrect publications.groupId and version (groupId becomes detekt and version becomes unspecified)
Fix
There does not seem to be a clean fix in the short-term. In the long term, we may consider moving non-shareable build logic outside
buildSrc.