Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven publish #3392

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix maven publish #3392

merged 1 commit into from
Jan 20, 2021

Conversation

chao2zhang
Copy link
Member

Issue

The deployment task failed: https://github.com/detekt/detekt/runs/1730645753
This issue is also observed locally that after ./gradlew publishToMavenLocal, we should see a directory structure like .m2/repository/io/gitlab/arturbosch/detekt/detekt-*. However, .m2/repository/detekt/detekt-* was observed.

Root cause

#3389 implicitly changed the order of

  • project.group and project.version (from commons.gradle.kts to root build.gradle)
  • publications.groupId and publications.version (in packaging.gradle.kts)

Switching the order resulted in incorrect publications.groupId and version (groupId becomes detekt and version becomes unspecified)

Fix

There does not seem to be a clean fix in the short-term. In the long term, we may consider moving non-shareable build logic outside buildSrc.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #3392 (e3fd6c8) into master (1164c34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3392   +/-   ##
=========================================
  Coverage     80.40%   80.40%           
  Complexity     2745     2745           
=========================================
  Files           448      448           
  Lines          8279     8279           
  Branches       1582     1582           
=========================================
  Hits           6657     6657           
  Misses          767      767           
  Partials        855      855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1164c34...4af112d. Read the comment docs.

@schalkms schalkms merged commit 425b67c into detekt:master Jan 20, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Feb 19, 2021
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants