Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentations on snapshots #3393

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

cortinico
Copy link
Member

I'm updating the documentation around using SNAPSHOTS as it was lacking.

Moreover I'm updating the SNAPSHOT name to be master-SNAPSHOT. If we don't like it we could use the upcoming version (but that forces us to keep two versions number updated).

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻👏🏻👏🏻 Nice one! And I like the master-SNAPSHOT name.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #3393 (cf2abc1) into master (1164c34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3393   +/-   ##
=========================================
  Coverage     80.40%   80.40%           
  Complexity     2745     2745           
=========================================
  Files           448      448           
  Lines          8279     8279           
  Branches       1582     1582           
=========================================
  Hits           6657     6657           
  Misses          767      767           
  Partials        855      855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1164c34...09b622b. Read the comment docs.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question if you may know the answer to.

}
```

Please note that the extra `resolutionStrategy{}` block is needed as we don't publish a Gradle Plugin marker for our snapshots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to read https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_markers. I am wondering why we don't publish a Gradle Plugin marker in our build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is here:

// hack to prevent building two jar's overwriting each other and leading to invalid signatures
// when publishing the Gradle plugin, this property must be present
isAutomatedPublishing = System.getProperty("automatePublishing")?.toBoolean() ?: false

I'm unsure of what was the exact issue with isAutomatedPublishing and the invalid signature, but we can definitely look into it.

docs/pages/snapshots.md Outdated Show resolved Hide resolved
docs/pages/snapshots.md Outdated Show resolved Hide resolved
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
@BraisGabin BraisGabin merged commit b0041fe into detekt:master Jan 20, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Feb 19, 2021
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants