-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentations on snapshots #3393
Update documentations on snapshots #3393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻👏🏻👏🏻👏🏻 Nice one! And I like the master-SNAPSHOT
name.
Codecov Report
@@ Coverage Diff @@
## master #3393 +/- ##
=========================================
Coverage 80.40% 80.40%
Complexity 2745 2745
=========================================
Files 448 448
Lines 8279 8279
Branches 1582 1582
=========================================
Hits 6657 6657
Misses 767 767
Partials 855 855 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question if you may know the answer to.
} | ||
``` | ||
|
||
Please note that the extra `resolutionStrategy{}` block is needed as we don't publish a Gradle Plugin marker for our snapshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came to read https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_markers. I am wondering why we don't publish a Gradle Plugin marker in our build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is here:
detekt/detekt-gradle-plugin/build.gradle.kts
Lines 58 to 60 in 1164c34
// hack to prevent building two jar's overwriting each other and leading to invalid signatures | |
// when publishing the Gradle plugin, this property must be present | |
isAutomatedPublishing = System.getProperty("automatePublishing")?.toBoolean() ?: false |
I'm unsure of what was the exact issue with isAutomatedPublishing
and the invalid signature, but we can definitely look into it.
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
I'm updating the documentation around using SNAPSHOTS as it was lacking.
Moreover I'm updating the SNAPSHOT name to be
master-SNAPSHOT
. If we don't like it we could use the upcoming version (but that forces us to keep two versions number updated).