Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for UnusedPrivateMember with expect on objects #3417

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

cortinico
Copy link
Member

We had a discrepancy on the visitClass and visitClassOrObject method (we were calling the wrong super method). I've fixed this, addressing the expect object scenarios.

Fixes #3415

@cortinico cortinico changed the title Fix false positive for with expect on objects Fix false positive for UnusedPrivateMember with expect on objects Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #3417 (58a3cff) into master (95a1220) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3417   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     2748     2748           
=========================================
  Files           449      449           
  Lines          8295     8297    +2     
  Branches       1587     1588    +1     
=========================================
+ Hits           6667     6669    +2     
  Misses          774      774           
  Partials        854      854           
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 90.76% <100.00%> (+0.14%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a1220...18a2187. Read the comment docs.

@schalkms schalkms merged commit 7924c7e into detekt:master Jan 27, 2021
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on UnusedPrivateMember for actual/expected inline method parameters.
3 participants