-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive for UnusedPrivateMember
with expect on objects
#3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
changed the title
Fix false positive for with expect on objects
Fix false positive for Jan 27, 2021
UnusedPrivateMember
with expect on objects
chao2zhang
approved these changes
Jan 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #3417 +/- ##
=========================================
Coverage 80.37% 80.37%
Complexity 2748 2748
=========================================
Files 449 449
Lines 8295 8297 +2
Branches 1587 1588 +1
=========================================
+ Hits 6667 6669 +2
Misses 774 774
Partials 854 854
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jan 27, 2021
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a discrepancy on the
visitClass
andvisitClassOrObject
method (we were calling the wrong super method). I've fixed this, addressing theexpect object
scenarios.Fixes #3415