Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix githubRelease skipping assets #3427

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

cortinico
Copy link
Member

Currently we fail to resolve project.version inside the githubRelease {} block. This is causing release artifacts to not be included in the release on Github.

This happens as the version is set after the precompiled plugin is applied.

Fixes #3425

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #3427 (c7056ee) into master (5077a4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3427   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     2749     2749           
=========================================
  Files           449      449           
  Lines          8301     8301           
  Branches       1590     1590           
=========================================
  Hits           6672     6672           
  Misses          774      774           
  Partials        855      855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5077a4c...c7056ee. Read the comment docs.

@schalkms schalkms merged commit 9327ebe into detekt:master Jan 29, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Feb 19, 2021
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants