Remove UnnecessarySafeCall safeguard against ErrorType

[cortinico]

Opening this to recall to remove this extra patch introduced in #3419
A fix was pushed upstream in the Kotlin compiler and should land in Kotlin 1.5

As soon as we bump the compiler-embeddable version we can also merge this PR (as the tests should be green)

[BraisGabin]

We should be able to unblock this now, right?

[cortinico]

Seems like the change didn't make to 1.5.0:
https://github.com/JetBrains/kotlin/blob/e73e039e43d740b890eaa4d7256362eeaf6ff1f7/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/CallExpressionResolver.kt#L542-L544

But is on master:
https://github.com/JetBrains/kotlin/blob/23faacd21b84af32921ecad785c8d30f1b930c34/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/CallExpressionResolver.kt#L545-L547

So we will probably have to wait a bit more

[picklebento]

Kotlin compiler fix is included in 1.5.20-M1, so we should be unblocked by then.

[picklebento]

Ooops sorry I misclicked the button.

[3flex]

I checked out this branch, rebased on main & ran a full build, so this just needs a rebase to check the CI passes on all platforms then it can be merged for 1.18.1 or 1.19.0.

[cortinico]

so this just needs a rebase to check the CI passes on all platforms

Just rebased 👍

[codecov]

Codecov Report

Merging #3439 (dad91a1) into main (3ecac0d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3439      +/-   ##
============================================
+ Coverage     83.58%   83.60%   +0.01%     
  Complexity     3187     3187              
============================================
  Files           459      459              
  Lines          9101     9099       -2     
  Branches       1772     1771       -1     
============================================
  Hits           7607     7607              
+ Misses          561      560       -1     
+ Partials        933      932       -1     

Impacted Files	Coverage Δ
...rturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt	80.95% <ø> (+7.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecac0d...dad91a1. Read the comment docs.