Skip to content

Silence IndexOutOfBoundsException in getLineAndColumnInPsiFile()#3446

Merged
picklebento merged 2 commits into
detekt:masterfrom
picklebento:silence
Feb 7, 2021
Merged

Silence IndexOutOfBoundsException in getLineAndColumnInPsiFile()#3446
picklebento merged 2 commits into
detekt:masterfrom
picklebento:silence

Conversation

@picklebento
Copy link
Copy Markdown
Member

@picklebento picklebento commented Feb 5, 2021

Rather than #3317, this is a short-term patch fix for #2693 and #3250.

This is verified by using the sample project https://github.com/andrey-bolduzev/detekt_issue_2693

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2021

Codecov Report

Merging #3446 (d796cfd) into master (fab88df) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3446      +/-   ##
============================================
- Coverage     80.28%   80.26%   -0.02%     
  Complexity     2785     2785              
============================================
  Files           454      454              
  Lines          8415     8418       +3     
  Branches       1609     1609              
============================================
+ Hits           6756     6757       +1     
- Misses          787      789       +2     
  Partials        872      872              
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/io/github/detekt/metrics/LinesOfCode.kt 87.50% <50.00%> (-5.61%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab88df...a826d4f. Read the comment docs.

@picklebento picklebento merged commit 1926972 into detekt:master Feb 7, 2021
@picklebento picklebento deleted the silence branch February 8, 2021 00:19
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants