Skip to content

Dont generate baseline if empty#3450

Merged
schalkms merged 5 commits intodetekt:masterfrom
BraisGabin:dont-generate-baseline-if-empty
Feb 17, 2021
Merged

Dont generate baseline if empty#3450
schalkms merged 5 commits intodetekt:masterfrom
BraisGabin:dont-generate-baseline-if-empty

Conversation

@BraisGabin
Copy link
Copy Markdown
Member

This PR is a rebase from #3027 full credit to @realdadfish

I added a new commit removing the output when the baseline is not generated. We had several PR already making detekt less noisy so I think that we should keep it like this. (Maybe for 2.0 we could implement a log system with different levels so this kind of output can be written at a verbose level).

Merge this PR is safe now. We already merged #3429

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2021

Codecov Report

Merging #3450 (713dcab) into master (623e7fd) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3450      +/-   ##
============================================
- Coverage     80.28%   80.27%   -0.01%     
- Complexity     2784     2786       +2     
============================================
  Files           454      454              
  Lines          8415     8416       +1     
  Branches       1608     1609       +1     
============================================
  Hits           6756     6756              
  Misses          789      789              
- Partials        870      871       +1     
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/core/baseline/BaselineFacade.kt 77.77% <0.00%> (ø) 6.00 <2.00> (ø)
...osch/detekt/core/baseline/BaselineResultMapping.kt 73.33% <77.77%> (-5.24%) 8.00 <3.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623e7fd...49364af. Read the comment docs.

@schalkms schalkms merged commit 408ad12 into detekt:master Feb 17, 2021
@cortinico cortinico added this to the 1.16.0 milestone Feb 19, 2021
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants