Dont generate baseline if empty#3450
Merged
schalkms merged 5 commits intodetekt:masterfrom Feb 17, 2021
BraisGabin:dont-generate-baseline-if-empty
Merged
Dont generate baseline if empty#3450schalkms merged 5 commits intodetekt:masterfrom BraisGabin:dont-generate-baseline-if-empty
schalkms merged 5 commits intodetekt:masterfrom
BraisGabin:dont-generate-baseline-if-empty
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3450 +/- ##
============================================
- Coverage 80.28% 80.27% -0.01%
- Complexity 2784 2786 +2
============================================
Files 454 454
Lines 8415 8416 +1
Branches 1608 1609 +1
============================================
Hits 6756 6756
Misses 789 789
- Partials 870 871 +1
Continue to review full report at Codecov.
|
cortinico
approved these changes
Feb 7, 2021
Co-authored-by: Artur Bosch <arturbosch@gmx.de>
schalkms
approved these changes
Feb 17, 2021
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rebase from #3027 full credit to @realdadfish
I added a new commit removing the output when the baseline is not generated. We had several PR already making detekt less noisy so I think that we should keep it like this. (Maybe for 2.0 we could implement a log system with different levels so this kind of output can be written at a verbose level).
Merge this PR is safe now. We already merged #3429