Move gradle testkit test back to test/ #3504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IntelliJ IDE by default will not recognize our custom source set as
test
. Therefore the dependencies can be inferred incorrectly. See the screenshot:It still won't work even if we use the idea gradle plugin as described in IDEA-151925.
Another problem with respect to IDE integration is that the code generated
DEFAULT_DETEKT_VERSION
cannot be correctly displayed.Main change
Moving these testkit tests back to
test/
would significantly improve the IDE experience: there is no IDE warnings or errors and we can continue run tests in IntelliJ.Other changes