Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Plugin tests should access also Maven Local #3510

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

cortinico
Copy link
Member

While preparing RC3, I noticed that Gradle plugin tests are failing once you bump version, even if you have the artifact on Maven Local.

Steps to reproduce:

  • Bump buildSrc/src/main/kotlin/Versions.kt
  • Run gradle publishToMavenLocal
  • Run gradle build

Tests are failing with:

    Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find io.gitlab.arturbosch.detekt:detekt-cli:1.16.0-RC3.
    Searched in the following locations:
      - https://repo.maven.apache.org/maven2/io/gitlab/arturbosch/detekt/detekt-cli/1.16.0-RC3/detekt-cli-1.16.0-RC3.pom
      - https://jcenter.bintray.com/io/gitlab/arturbosch/detekt/detekt-cli/1.16.0-RC3/detekt-cli-1.16.0-RC3.pom
    Required by:
        project :

    * Get more help at https://help.gradle.org
    BUILD FAILED in 1s

@cortinico cortinico added this to the 1.16.0 milestone Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3510 (2fa1b45) into master (c5f65a9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3510      +/-   ##
============================================
- Coverage     77.63%   77.61%   -0.02%     
- Complexity     2814     2817       +3     
============================================
  Files           462      462              
  Lines          8709     8720      +11     
  Branches       1688     1692       +4     
============================================
+ Hits           6761     6768       +7     
  Misses         1036     1036              
- Partials        912      916       +4     
Impacted Files Coverage Δ Complexity Δ
...s/exceptions/ThrowingNewInstanceOfSameException.kt 50.00% <0.00%> (-5.56%) 7.00% <0.00%> (+3.00%) ⬇️
...bosch/detekt/rules/complexity/MethodOverloading.kt 91.42% <0.00%> (-1.43%) 5.00% <0.00%> (+1.00%) ⬇️
...b/arturbosch/detekt/rules/style/UseCheckNotNull.kt 90.00% <0.00%> (-0.91%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f65a9...1bab8ac. Read the comment docs.

@chao2zhang chao2zhang merged commit 44b7847 into detekt:master Mar 3, 2021
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants