Skip to content

Allow opt-out configuring detekt android and multiplatform #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

chao2zhang
Copy link
Member

Detekt Android can worsen the user experience in case of

For those "experimental" gradle plugin setups, we should provide a way to allow users to opt-out to unblock users from upgrading.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3511 (6d16c25) into master (44b7847) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3511      +/-   ##
============================================
- Coverage     77.61%   77.59%   -0.02%     
  Complexity     2817     2817              
============================================
  Files           462      462              
  Lines          8720     8722       +2     
  Branches       1692     1694       +2     
============================================
  Hits           6768     6768              
- Misses         1036     1038       +2     
  Partials        916      916              
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 6.00% <0.00%> (-0.25%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b7847...2c380fb. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this PR but I must admit that I have no idea how this help our users or why this creates issues

@chao2zhang
Copy link
Member Author

I'm ok with this PR but I must admit that I have no idea how this help our users or why this creates issues

This can help users to upgrade detekt versions while giving us more breathing room to debug Detekt Android/Multiplatform related issues.

@chao2zhang chao2zhang merged commit fe9c486 into detekt:master Mar 5, 2021
@chao2zhang chao2zhang deleted the optout branch March 5, 2021 06:36
@cortinico cortinico added this to the 1.16.0 milestone Mar 5, 2021
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants