-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge SARIF reports #3522
Merge SARIF reports #3522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
============================================
- Coverage 77.59% 77.53% -0.07%
- Complexity 2817 2829 +12
============================================
Files 462 464 +2
Lines 8722 8769 +47
Branches 1694 1713 +19
============================================
+ Hits 6768 6799 +31
- Misses 1038 1046 +8
- Partials 916 924 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I've left a minor comment for a refactoring. But we can also skip it if we wish
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/report/SarifReportMergeTask.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
This PR addresses the last item in #3360
Notes
Although Gradle repackages Jackson dependency internally, its version seems outdated and I encountered two parsing issues. Therefore, I am adding the latest Jackson dependency explicitly.
-Dorg.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m
becomes necessary. It turns out thatDetektSarifReportMergeTest.kt
runs out of Metaspace as OutOfMemoryError with Java 11 + Ubuntu/Windows. Hence I am bumping the Xmx and MaxMetaspaceSize slightly for test to pass.