Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
============================================
- Coverage 77.59% 77.53% -0.07%
- Complexity 2817 2829 +12
============================================
Files 462 464 +2
Lines 8722 8769 +47
Branches 1694 1713 +19
============================================
+ Hits 6768 6799 +31
- Misses 1038 1046 +8
- Partials 916 924 +8
Continue to review full report at Codecov.
|
cortinico
approved these changes
Mar 8, 2021
Member
cortinico
left a comment
There was a problem hiding this comment.
LGTM 👍 I've left a minor comment for a refactoring. But we can also skip it if we wish
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/report/SarifReportMergeTask.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
cortinico
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the last item in #3360
Notes
Although Gradle repackages Jackson dependency internally, its version seems outdated and I encountered two parsing issues. Therefore, I am adding the latest Jackson dependency explicitly.
-Dorg.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512mbecomes necessary. It turns out thatDetektSarifReportMergeTest.ktruns out of Metaspace as OutOfMemoryError with Java 11 + Ubuntu/Windows. Hence I am bumping the Xmx and MaxMetaspaceSize slightly for test to pass.