Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SARIF reports #3522

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Merge SARIF reports #3522

merged 7 commits into from
Mar 10, 2021

Conversation

chao2zhang
Copy link
Member

This PR addresses the last item in #3360

Notes

  1. Although Gradle repackages Jackson dependency internally, its version seems outdated and I encountered two parsing issues. Therefore, I am adding the latest Jackson dependency explicitly.

  2. -Dorg.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m becomes necessary. It turns out that DetektSarifReportMergeTest.kt runs out of Metaspace as OutOfMemoryError with Java 11 + Ubuntu/Windows. Hence I am bumping the Xmx and MaxMetaspaceSize slightly for test to pass.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #3522 (34866b0) into master (fe9c486) will decrease coverage by 0.06%.
The diff coverage is 60.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3522      +/-   ##
============================================
- Coverage     77.59%   77.53%   -0.07%     
- Complexity     2817     2829      +12     
============================================
  Files           462      464       +2     
  Lines          8722     8769      +47     
  Branches       1694     1713      +19     
============================================
+ Hits           6768     6799      +31     
- Misses         1038     1046       +8     
- Partials        916      924       +8     
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 21.42% <0.00%> (ø) 4.00 <0.00> (ø)
...gitlab/arturbosch/detekt/report/ReportMergeTask.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rturbosch/detekt/rules/bugs/UnusedUnaryOperator.kt 59.09% <59.09%> (ø) 8.00 <8.00> (?)
...tlab/arturbosch/detekt/report/SarifReportMerger.kt 91.66% <91.66%> (ø) 3.00 <3.00> (?)
...enerator/printer/rulesetpage/RuleSetPagePrinter.kt 87.80% <100.00%> (+0.96%) 16.00 <0.00> (ø)
...turbosch/detekt/rules/bugs/PotentialBugProvider.kt 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...osch/detekt/rules/exceptions/SwallowedException.kt 77.35% <100.00%> (+2.35%) 19.00 <1.00> (+1.00)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9c486...0236dbd. Read the comment docs.

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I've left a minor comment for a refactoring. But we can also skip it if we wish

@chao2zhang chao2zhang merged commit bfc0863 into detekt:master Mar 10, 2021
@cortinico cortinico added this to the 1.16.0 milestone Mar 10, 2021
@chao2zhang chao2zhang deleted the merge-sarif branch March 15, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants