Swallow exception fixes

[sschuberth]

What all by default ignored exceptions have in common is that none of
their constructors allows to pass an exception as the cause. Thus, it
does not make sense to complain when these are used in the catch body to
replace the original exception.

Fixes #3524.

[schalkms]

Cool, thanks for improving this rule! 🙂
I think a sample or sentence in the rule doc could help to better recall this change.

[codecov]

Codecov Report

Merging #3525 (ba026d4) into master (2fbb7c9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3525      +/-   ##
============================================
+ Coverage     77.56%   77.57%   +0.01%     
- Complexity     2825     2826       +1     
============================================
  Files           463      463              
  Lines          8745     8746       +1     
  Branches       1703     1704       +1     
============================================
+ Hits           6783     6785       +2     
  Misses         1038     1038              
+ Partials        924      923       -1     

Impacted Files	Coverage Δ	Complexity Δ
...osch/detekt/rules/exceptions/SwallowedException.kt	77.35% <100.00%> (+2.35%)	19.00 <1.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbb7c9...0461e8e. Read the comment docs.

[sschuberth]

I think a sample or sentence in the rule doc could help to better recall this change.

I've anyway filed another ticket for improving the docs, see #3523. Will do that when addressing that issue, too.

[schalkms]

@sschuberth good to know. It's okay for me. LGTM!

[sschuberth]

Will this still make it into 1.16.0 final? (As I believe otherwise more people will come across this issue, as this rule is active by default starting with 1.16.0.)

[schalkms]

Will this still make it into 1.16.0 final? (As I believe otherwise more people will come across this issue, as this rule is active by default starting with 1.16.0.)

yes 🙂