Fix Markdown rendering of multiple default values#3526
Merged
Conversation
As it does not really look good, esp. in Markdown, to have an enumeration rendered as a code block when surrounded by "(default: ...)" in regular text, simply turn the enumeration into a comma separated list. Fixes detekt#3523.
schalkms
approved these changes
Mar 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #3526 +/- ##
============================================
+ Coverage 77.56% 77.58% +0.02%
- Complexity 2825 2826 +1
============================================
Files 463 463
Lines 8745 8749 +4
Branches 1703 1704 +1
============================================
+ Hits 6783 6788 +5
Misses 1038 1038
+ Partials 924 923 -1
Continue to review full report at Codecov.
|
Contributor
Author
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Please have a look at the individual commit messages for the details.