Markdown: Reintroduce double-backticks for inline code rendering#3545
Markdown: Reintroduce double-backticks for inline code rendering#3545BraisGabin merged 1 commit intodetekt:mainfrom
Conversation
schalkms
left a comment
There was a problem hiding this comment.
Wouldn't it make more sense to remove the occurrences that contain back-ticks in order to avoid this special case here? What do you think? @BraisGabin
|
How would you avoid this? https://detekt.github.io/detekt/naming.html#functionnaming What's the problem with the double tick? |
@BraisGabin one can avoid this scenario by putting three back-ticks around it '```'. |
That would make us to change the documentation and now that we are introducing the |
|
The official Markdown guide specifies the double back-tick as a valid way to escape a code snippet [1]. Hence, this is fine for me. [1] https://www.markdownguide.org/basic-syntax/#escaping-backticks |
|
The test suite is unfortunately not green for this PR. |
This partly reverts 9cf9f08 and add a code comment to explain why the double-backticks were in fact intended, also see detekt#3523 (comment)
3030d94 to
e77c15c
Compare
Should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## main #3545 +/- ##
============================================
+ Coverage 77.53% 78.22% +0.69%
+ Complexity 2835 2826 -9
============================================
Files 464 466 +2
Lines 8779 9136 +357
Branches 1720 1724 +4
============================================
+ Hits 6807 7147 +340
- Misses 1046 1059 +13
- Partials 926 930 +4
Continue to review full report at Codecov.
|
This partly reverts 9cf9f08 and add a code comment to explain why the
double-backticks were in fact intended, also see
#3523 (comment)