Skip to content

Conversation

@chao2zhang
Copy link
Member

Size of detekt-report-sarif jar: 2.2MB -> 15KB

Noticeable change

I was not able to find a JSONSchema -> Kotlin data class annotated with Kotlinx-serialization tool that preserves the order.

In the end, object JSON Schema should expect to have a unordered set of properties according to https://tools.ietf.org/html/draft-wright-json-schema-00#section-4.2, but as mentioned in #3045 (comment), it is still recommended to preserve order for streaming parsing consumers.

TODO

Port #3556

@chao2zhang chao2zhang changed the title Sarif4k Switch SARIF report off jackson Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #3557 (f889fb7) into main (b72898b) will decrease coverage by 0.04%.
The diff coverage is 74.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3557      +/-   ##
============================================
- Coverage     78.04%   78.00%   -0.05%     
  Complexity     2837     2837              
============================================
  Files           467      467              
  Lines          9152     9135      -17     
  Branches       1742     1737       -5     
============================================
- Hits           7143     7126      -17     
  Misses         1067     1067              
  Partials        942      942              
Impacted Files Coverage Δ Complexity Δ
...n/io/github/detekt/report/sarif/RuleDescriptors.kt 28.57% <17.64%> (+8.57%) 0.00 <0.00> (ø)
...tlab/arturbosch/detekt/report/SarifReportMerger.kt 66.66% <60.00%> (-25.00%) 2.00 <1.00> (-1.00)
...in/kotlin/io/github/detekt/report/sarif/Results.kt 95.65% <95.65%> (ø) 0.00 <0.00> (?)
...io/github/detekt/report/sarif/SarifOutputReport.kt 90.62% <100.00%> (+0.14%) 5.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72898b...f889fb7. Read the comment docs.

@chao2zhang chao2zhang linked an issue Mar 20, 2021 that may be closed by this pull request
Base automatically changed from master to main March 21, 2021 18:44
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have little context on this part of the codebase, but the change looks sane to me 👍

@chao2zhang chao2zhang marked this pull request as ready for review March 23, 2021 06:20
@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 1, 2021
@chao2zhang chao2zhang merged commit cff4f55 into detekt:main Apr 6, 2021
@chao2zhang chao2zhang deleted the sarif4k branch October 13, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch SARIF report off jackson

4 participants