-
-
Notifications
You must be signed in to change notification settings - Fork 821
Switch SARIF report off jackson #3557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3557 +/- ##
============================================
- Coverage 78.04% 78.00% -0.05%
Complexity 2837 2837
============================================
Files 467 467
Lines 9152 9135 -17
Branches 1742 1737 -5
============================================
- Hits 7143 7126 -17
Misses 1067 1067
Partials 942 942
Continue to review full report at Codecov.
|
cortinico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have little context on this part of the codebase, but the change looks sane to me 👍
Size of detekt-report-sarif jar: 2.2MB -> 15KB
Noticeable change
I was not able to find a JSONSchema -> Kotlin data class annotated with Kotlinx-serialization tool that preserves the order.
propertyOrderbut requires changing the JSON schema.In the end, object JSON Schema should expect to have a unordered set of properties according to https://tools.ietf.org/html/draft-wright-json-schema-00#section-4.2, but as mentioned in #3045 (comment), it is still recommended to preserve order for streaming parsing consumers.
TODO
Port #3556