Skip to content

Revert "Refactor Analyzer so that RuleSetProvider.instance is only called once"#3578

Merged
schalkms merged 1 commit intomasterfrom
revert-3555-cazhang/idmapping
Mar 19, 2021
Merged

Revert "Refactor Analyzer so that RuleSetProvider.instance is only called once"#3578
schalkms merged 1 commit intomasterfrom
revert-3555-cazhang/idmapping

Conversation

@picklebento
Copy link
Copy Markdown
Member

Reverts #3555

@picklebento
Copy link
Copy Markdown
Member Author

The original PR is intended for 1.17+

@picklebento picklebento added this to the 1.16.1 milestone Mar 19, 2021
Copy link
Copy Markdown
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my bad, I overlooked that.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2021

Codecov Report

Merging #3578 (be64658) into master (1b45d78) will increase coverage by 0.01%.
The diff coverage is 92.85%.

❗ Current head be64658 differs from pull request most recent head 789fa31. Consider uploading reports for the commit 789fa31 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
+ Coverage     77.52%   77.53%   +0.01%     
  Complexity     2829     2829              
============================================
  Files           464      464              
  Lines          8769     8769              
  Branches       1713     1713              
============================================
+ Hits           6798     6799       +1     
+ Misses         1047     1046       -1     
  Partials        924      924              
Impacted Files Coverage Δ Complexity Δ
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 81.08% <80.00%> (+0.81%) 9.00 <0.00> (ø)
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b45d78...789fa31. Read the comment docs.

@schalkms schalkms merged commit 3c64da7 into master Mar 19, 2021
@schalkms schalkms deleted the revert-3555-cazhang/idmapping branch March 19, 2021 21:38
@picklebento picklebento modified the milestones: 1.16.1, 1.17.0 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants