Skip to content

SarifOutputReportSpec: Correctly detect Windows root directory on local development machine#3584

Merged
picklebento merged 2 commits into
detekt:mainfrom
bedla:win-local-tests-run
Mar 22, 2021
Merged

SarifOutputReportSpec: Correctly detect Windows root directory on local development machine#3584
picklebento merged 2 commits into
detekt:mainfrom
bedla:win-local-tests-run

Conversation

@bedla

@bedla bedla commented Mar 21, 2021

Copy link
Copy Markdown
Contributor

Hi,
while experimenting with Detekt source code I found that test SarifOutputReportSpec is failing on my Windows machine because of C: vs D: Windows root dir detection. So I have created this PR to solve this problem.
Hope it helps and is ok,
Ivos

@bedla bedla force-pushed the win-local-tests-run branch from 9f84ece to e837285 Compare March 21, 2021 11:46
@codecov

codecov Bot commented Mar 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3584 (23fc6c5) into main (c32b041) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 23fc6c5 differs from pull request most recent head a51ea20. Consider uploading reports for the commit a51ea20 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3584   +/-   ##
=========================================
  Coverage     77.52%   77.53%           
- Complexity     2829     2835    +6     
=========================================
  Files           464      464           
  Lines          8767     8779   +12     
  Branches       1713     1720    +7     
=========================================
+ Hits           6797     6807   +10     
  Misses         1046     1046           
- Partials        924      926    +2     
Impacted Files Coverage Δ Complexity Δ
...in/kotlin/io/github/detekt/report/xml/XmlEscape.kt 64.28% <ø> (ø) 3.00 <0.00> (ø)
...turbosch/detekt/rules/bugs/NullableToStringCall.kt 76.19% <ø> (ø) 21.00 <0.00> (ø)
...t/rules/naming/NonBooleanPropertyPrefixedWithIs.kt 85.18% <ø> (ø) 12.00 <0.00> (ø)
...kt/rules/style/LibraryEntitiesShouldNotBePublic.kt 83.33% <ø> (ø) 7.00 <0.00> (ø)
...b/arturbosch/detekt/rules/style/UseCheckNotNull.kt 90.00% <ø> (ø) 3.00 <0.00> (-1.00)
...arturbosch/detekt/rules/style/UseRequireNotNull.kt 90.90% <ø> (ø) 5.00 <0.00> (ø)
...enerator/printer/rulesetpage/RuleSetPagePrinter.kt 86.36% <66.66%> (-1.45%) 18.00 <0.00> (+2.00) ⬇️
...urbosch/detekt/generator/collection/RuleVisitor.kt 82.45% <87.50%> (+0.38%) 43.00 <0.00> (+4.00)
...lab/arturbosch/detekt/generator/collection/Rule.kt 93.33% <100.00%> (+0.47%) 10.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32b041...a51ea20. Read the comment docs.

Base automatically changed from master to main March 21, 2021 18:44
@bedla bedla force-pushed the win-local-tests-run branch from e837285 to a265c9e Compare March 22, 2021 06:41
@bedla

bedla commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

Seems Gradle crashed badly, do I have to do something with it?

@picklebento

Copy link
Copy Markdown
Member

No worries. This is a known flakiness. I will merge this PR.

@picklebento picklebento merged commit 8dbb01f into detekt:main Mar 22, 2021
@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants