Skip to content

Refactor Analyzer so that RuleSetProvider.instance is only called once #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

chao2zhang
Copy link
Member

As we are still conforming to single branch development. This is a resubmission of #3555 as it was reverted.

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #3585 (861df84) into master (091dc91) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3585      +/-   ##
============================================
- Coverage     77.53%   77.52%   -0.02%     
  Complexity     2835     2835              
============================================
  Files           464      464              
  Lines          8779     8779              
  Branches       1720     1720              
============================================
- Hits           6807     6806       -1     
- Misses         1046     1047       +1     
  Partials        926      926              
Impacted Files Coverage Δ Complexity Δ
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 80.26% <71.42%> (-0.82%) 9.00 <0.00> (ø)
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091dc91...861df84. Read the comment docs.

Base automatically changed from master to main March 21, 2021 18:44
@cortinico cortinico added this to the 1.17.0 milestone Mar 22, 2021
@chao2zhang chao2zhang merged commit 4a89a25 into detekt:main Mar 24, 2021
@chao2zhang chao2zhang deleted the cazhang/idmapping branch May 21, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants