[MemberNameEqualsClassName] Support factory exemption for generic classes

[josephlbarnett]

Compare the referenced type name instead of the fully
qualified generic type name when possible.

Fixes #3591

[josephlbarnett]

There may be a better way to do this, as I don't fully understand the kotlin compiler psi APIs, but this works for the test case included and falls back to the previous implementation for other cases.

[codecov]

Codecov Report

Merging #3595 (71001e5) into main (8dbb01f) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 71001e5 differs from pull request most recent head 3017ef2. Consider uploading reports for the commit 3017ef2 to get more accurate results

@@             Coverage Diff              @@
##               main    #3595      +/-   ##
============================================
- Coverage     77.53%   77.53%   -0.01%     
- Complexity     2835     2837       +2     
============================================
  Files           464      464              
  Lines          8779     8783       +4     
  Branches       1720     1721       +1     
============================================
+ Hits           6807     6810       +3     
  Misses         1046     1046              
- Partials        926      927       +1     

Impacted Files	Coverage Δ	Complexity Δ
...h/detekt/rules/naming/MemberNameEqualsClassName.kt	77.14% <66.66%> (-1.65%)	13.00 <0.00> (ø)
...bosch/detekt/rules/complexity/MethodOverloading.kt	91.66% <0.00%> (+0.23%)	5.00% <0.00%> (ø%)
...b/arturbosch/detekt/rules/style/UseCheckNotNull.kt	90.90% <0.00%> (+0.90%)	5.00% <0.00%> (+2.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbb01f...3017ef2. Read the comment docs.

[BraisGabin]

In this test is not clear if the problem was the generic in the class or the generic in the function. Could you simplify it? Or, if they are both, create two tests.

[josephlbarnett]

Added a non-generic factory function to the test, does that help?

[BraisGabin]

Which is the problem exactly this code:

                    data class GenericClass(val wrapped: Any) {
                        companion object {
                            fun <T> genericClass(wrapped: T): GenericClass<T> {
                                return GenericClass(wrapped)
                            }
                        }
                    }

or this:

                    data class GenericClass<T>(val wrapped: T) {
                        companion object {
                            fun genericClass(wrapped: Any): GenericClass<Any> {
                                return GenericClass(wrapped)
                            }
                        }
                    }

[josephlbarnett]

the top one is closer to real world usage, but i suppose the bottom one is the minimal example? both fail without the change and pass with it, fwiw.