Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Deprecation and Documentation for allRules #3596

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

cortinico
Copy link
Member

Fixes #3567

This PR adds:

  • Documentation for the allRules property in the Gradle documentation page
  • A Deprecation annotation on the allRules accessors in the extention an the tasks.
  • More spacing in the Gradle config page as it's getting harder to read

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #3596 (421934b) into main (c16ecf6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3596   +/-   ##
=========================================
  Coverage     77.53%   77.53%           
  Complexity     2835     2835           
=========================================
  Files           464      464           
  Lines          8779     8779           
  Branches       1720     1720           
=========================================
  Hits           6807     6807           
  Misses         1046     1046           
  Partials        926      926           
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlab/arturbosch/detekt/DetektCreateBaselineTask.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ab/arturbosch/detekt/extensions/DetektExtension.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16ecf6...421934b. Read the comment docs.

@cortinico cortinico merged commit abe36cd into detekt:main Mar 23, 2021
@cortinico cortinico deleted the nc/update-docs-for-allRules branch March 23, 2021 21:36
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Mar 23, 2021
@cortinico cortinico added this to the 1.17.0 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird warning recommending to use undocumented options
4 participants