Skip to content

Fix CI failure for deploy-snapshot - #3598

Merged
picklebento merged 1 commit into
detekt:mainfrom
picklebento:cazhang/publishSnapshot
Mar 23, 2021
Merged

Fix CI failure for deploy-snapshot#3598
picklebento merged 1 commit into
detekt:mainfrom
picklebento:cazhang/publishSnapshot

Conversation

@picklebento

Copy link
Copy Markdown
Member

Summary

Deploy snapshot has been broken since #3574

Execution failed for task ':detekt-cli:publishDetektPublicationPublicationToSonatypeSnapshotRepository'.
> Failed to publish publication 'DetektPublication' to repository 'sonatypeSnapshot'
   > Invalid publication 'DetektPublication': multiple artifacts with the identical extension and classifier ('jar', 'all').

The problem is that we bumped the shadow from 5.2.0 to 6.1.0. It turns out that Shadow 6.0.0 has a behavior change that shadowed jar is added to the publishing artifacts by default. It is likely impacted by this change GradleUp/shadow@5c572a6

Testing done

I have manually verified that we are adding one and only one detekt-cli-1.16.0-all.jar into publishing artifacts through local debugging.

@picklebento
picklebento requested a review from 3flex March 23, 2021 03:28
@codecov

codecov Bot commented Mar 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3598 (18ecd59) into main (8dbb01f) will not change coverage.
The diff coverage is n/a.

❗ Current head 18ecd59 differs from pull request most recent head 12826a5. Consider uploading reports for the commit 12826a5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3598   +/-   ##
=========================================
  Coverage     77.53%   77.53%           
  Complexity     2835     2835           
=========================================
  Files           464      464           
  Lines          8779     8779           
  Branches       1720     1720           
=========================================
  Hits           6807     6807           
  Misses         1046     1046           
  Partials        926      926           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbb01f...12826a5. Read the comment docs.

@3flex

3flex commented Mar 23, 2021

Copy link
Copy Markdown
Member

Sorry about that, typically Shadow updates (even across major versions) were just about bug fixing and maintaining Gradle compatibility.

@3flex 3flex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your manual testing so hopefully a quick merge will resolve that issue. Thanks for identifying & finding the fix!

@picklebento

picklebento commented Mar 23, 2021

Copy link
Copy Markdown
Member Author

Once merged, I can verify if the detekt-cli-<version>-all.jar is still published to snapshot repository

@picklebento
picklebento merged commit 0b13b07 into detekt:main Mar 23, 2021
@picklebento

Copy link
Copy Markdown
Member Author

Verified in sonatype that detekt-cli-<version>-all.jar is uploaded correctly.
image

@picklebento
picklebento deleted the cazhang/publishSnapshot branch March 23, 2021 16:24
@picklebento picklebento added this to the 1.17.0 milestone Mar 27, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants