-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failure for deploy-snapshot #3598
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3598 +/- ##
=========================================
Coverage 77.53% 77.53%
Complexity 2835 2835
=========================================
Files 464 464
Lines 8779 8779
Branches 1720 1720
=========================================
Hits 6807 6807
Misses 1046 1046
Partials 926 926 Continue to review full report at Codecov.
|
Sorry about that, typically Shadow updates (even across major versions) were just about bug fixing and maintaining Gradle compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust your manual testing so hopefully a quick merge will resolve that issue. Thanks for identifying & finding the fix!
Once merged, I can verify if the |
Summary
Deploy snapshot has been broken since #3574
The problem is that we bumped the shadow from 5.2.0 to 6.1.0. It turns out that Shadow 6.0.0 has a behavior change that shadowed jar is added to the publishing artifacts by default. It is likely impacted by this change GradleUp/shadow@5c572a6
Testing done
I have manually verified that we are adding one and only one
detekt-cli-1.16.0-all.jar
into publishing artifacts through local debugging.