-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --stacktrace to help triage CI flakiness #3604
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3604 +/- ##
============================================
- Coverage 77.53% 77.53% -0.01%
- Complexity 2835 2837 +2
============================================
Files 464 464
Lines 8779 8781 +2
Branches 1720 1720
============================================
+ Hits 6807 6808 +1
- Misses 1046 1047 +1
Partials 926 926
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? Don't we upload all our builds to gradle scan?
I don't think we have build scan enabled in CI. Do you suggest adding |
I though that we had it by default. But we don't: Lines 14 to 17 in 4a89a25
We just enabled the permission |
I think what you are suggesting is https://docs.gradle.com/enterprise/gradle-plugin/#publishing_every_build
However, I don't think we should have that block in the main repo -
|
In short, there is still value by adding |
There seem to be a recent spike of CI random failures such as
https://github.com/detekt/detekt/pull/3595/checks?check_run_id=2178012720
I am adding
--stacktrace
to all gradle commands in CI to yield more debugging information in the CI failure.(Some gradle commands already come with
--stacktrace
)Meanwhile, I am also removing
--parallel
since we already have it set to true ingradle.properties
.