Skip to content

Update to Kotlin 1.4.32 #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Update to Kotlin 1.4.32 #3606

merged 1 commit into from
Mar 31, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Mar 25, 2021

It's not officially released yet (though the JARs were published to Maven Central) so there's no changelog to confirm KT-45007 fix was included, but the issue on YouTrack states it's fixed in this version so it should be safe to update.

See #3514 (comment)

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #3606 (a04039e) into main (37e3cc7) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a04039e differs from pull request most recent head 2891025. Consider uploading reports for the commit 2891025 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3606      +/-   ##
============================================
- Coverage     77.53%   77.51%   -0.02%     
  Complexity     2837     2837              
============================================
  Files           464      464              
  Lines          8781     8781              
  Branches       1720     1720              
============================================
- Hits           6808     6807       -1     
- Misses         1047     1048       +1     
  Partials        926      926              
Impacted Files Coverage Δ Complexity Δ
...o/gitlab/arturbosch/detekt/rules/KtModifierList.kt 91.66% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e3cc7...2891025. Read the comment docs.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking to @cortinico the other day about Kotlin 1.4.32 published to mavenCentral() without release notes.

@chao2zhang
Copy link
Member

but the issue on YouTrack states it's fixed in this version so it should be safe to update.

I verified kotlin-compiler-1.4.32-sources.jar, the KotlinCoreEnviroment.kt does not include the change in this commit JetBrains/kotlin@99a6bde
Let's wait for the official announcement of 1.4.32.

@3flex
Copy link
Member Author

3flex commented Mar 25, 2021

That sounds right then. The fix for the issue is JetBrains/kotlin@e7e17cd which is a revert of the commit you've linked to.

Edit: We can still wait for a few hours/days for the official release & release notes.

@chao2zhang
Copy link
Member

My bad. I didn't closely read the comments in KT-45007. So kotlin-compiler-1.4.32-sources.jar should have the reverted version:

                // Disposing of the environment is unsafe in production then parallel builds are enabled, but turning it off universally
                // breaks a lot of tests, therefore it is disabled for production and enabled for tests
                if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY).toBooleanLenient() != true) {
                    // JPS may run many instances of the compiler in parallel (there's an option for compiling independent modules in parallel in IntelliJ)
                    // All projects share the same ApplicationEnvironment, and when the last project is disposed, the ApplicationEnvironment is disposed as well
                    Disposer.register(parentDisposable, Disposable {
                        synchronized(APPLICATION_LOCK) {
                            if (--ourProjectCount <= 0) {
                                disposeApplicationEnvironment()
                            }
                        }
                    })
                }

@cortinico
Copy link
Member

Edit: We can still wait for a few hours/days for the official release & release notes.

+1 for this

@cortinico cortinico added this to the 1.17.0 milestone Mar 26, 2021
@3flex
Copy link
Member Author

3flex commented Mar 30, 2021

https://github.com/JetBrains/kotlin/releases/tag/v1.4.32

KT-45007 confirmed fixed.

@3flex 3flex removed the blocked label Mar 30, 2021
@BraisGabin
Copy link
Member

@BraisGabin BraisGabin merged commit 2dd29ef into main Mar 31, 2021
@BraisGabin BraisGabin deleted the kotlin-1.4.32 branch March 31, 2021 16:31
@cortinico cortinico added the dependencies Pull requests that update a dependency file label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants