-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Gradle config #3612
Simplify Gradle config #3612
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3612 +/- ##
=========================================
Coverage 77.52% 77.52%
Complexity 2837 2837
=========================================
Files 464 464
Lines 8783 8783
Branches 1721 1721
=========================================
Hits 6809 6809
Misses 1047 1047
Partials 927 927 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The javadoc jars are empty anyway with the current config
Should we create a new issue to track this?
I don't think so. IIRC the javadoc jars are only created to satisfy a Maven Central requirement to provide them on upload, even if they're empty. The public Kotlin API is documented on the detekt website and since this is a Kotlin-only project I don't think it makes sense to publish Javadoc which would cover the Java flavour of the API. |
Uses withJavadocJar and withSourcesJar which are functionally equivalent to the config that was removed.
The new config also avoids configuring the javadoc/sourcesjar tasks during Gradle's configuration phase.
Tested by publishing to mavenLocal on my machine. The javadoc jars are empty anyway with the current config, and sources are published as expected.