Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Gradle config #3612

Merged
merged 2 commits into from
Mar 28, 2021
Merged

Simplify Gradle config #3612

merged 2 commits into from
Mar 28, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Mar 27, 2021

Uses withJavadocJar and withSourcesJar which are functionally equivalent to the config that was removed.

The new config also avoids configuring the javadoc/sourcesjar tasks during Gradle's configuration phase.

Tested by publishing to mavenLocal on my machine. The javadoc jars are empty anyway with the current config, and sources are published as expected.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #3612 (5452c0d) into main (dfdec5c) will not change coverage.
The diff coverage is n/a.

❗ Current head 5452c0d differs from pull request most recent head ff9d6d8. Consider uploading reports for the commit ff9d6d8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3612   +/-   ##
=========================================
  Coverage     77.52%   77.52%           
  Complexity     2837     2837           
=========================================
  Files           464      464           
  Lines          8783     8783           
  Branches       1721     1721           
=========================================
  Hits           6809     6809           
  Misses         1047     1047           
  Partials        927      927           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdec5c...ff9d6d8. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.17.0 milestone Mar 27, 2021
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The javadoc jars are empty anyway with the current config

Should we create a new issue to track this?

@3flex
Copy link
Member Author

3flex commented Mar 28, 2021

Should we create a new issue to track this?

I don't think so. IIRC the javadoc jars are only created to satisfy a Maven Central requirement to provide them on upload, even if they're empty. The public Kotlin API is documented on the detekt website and since this is a Kotlin-only project I don't think it makes sense to publish Javadoc which would cover the Java flavour of the API.

@3flex 3flex merged commit 84009f2 into detekt:main Mar 28, 2021
@3flex 3flex deleted the simplify branch March 28, 2021 05:23
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants