Replace getJetTypeFqName with fqNameOrNull extension#3613
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3613 +/- ##
============================================
- Coverage 78.22% 78.16% -0.07%
+ Complexity 2826 2825 -1
============================================
Files 466 467 +1
Lines 9136 9138 +2
Branches 1724 1731 +7
============================================
- Hits 7147 7143 -4
Misses 1059 1059
- Partials 930 936 +6 Continue to review full report at Codecov.
|
schalkms
approved these changes
Mar 27, 2021
This is from the org.jetbrains.kotlin.js package which should be avoided while detekt is limited to Kotlin/JVM analysis only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3605
This extension isn't a 1:1 replacement for
getJetTypeFqNamesince that function has some extra logic built in to print type arguments, but that isn't used by any rules so this replacement should do the trick.It returns the FqName instead of String like the old function did, but that might actually be more useful depending on how it's used.
I've also found the property
nameIfStandardTypewas also imported from thejspackage so I've refactored to avoid its use.