Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #3618

Merged
merged 6 commits into from
Mar 28, 2021
Merged

Improve tests #3618

merged 6 commits into from
Mar 28, 2021

Conversation

BraisGabin
Copy link
Member

This is a boy scout PR. I'm just preparing the tests to add some more meat on them. I think that reviewing it commit by commit will help to understand it.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #3618 (3fb8ad1) into main (7c4a690) will not change coverage.
The diff coverage is n/a.

❗ Current head 3fb8ad1 differs from pull request most recent head 85b1568. Consider uploading reports for the commit 85b1568 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3618   +/-   ##
=========================================
  Coverage     77.58%   77.58%           
  Complexity     2832     2832           
=========================================
  Files           465      465           
  Lines          8807     8807           
  Branches       1720     1720           
=========================================
  Hits           6833     6833           
  Misses         1047     1047           
  Partials        927      927           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4a690...85b1568. Read the comment docs.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding test coverage for type resolution and detektTest

@BraisGabin BraisGabin merged commit 99ca715 into main Mar 28, 2021
@BraisGabin BraisGabin deleted the improve-tests branch March 28, 2021 22:32
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Mar 28, 2021
@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants