Skip to content

Improve tests from :detekt-gradle-plugin #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2021
Merged

Conversation

BraisGabin
Copy link
Member

More refactor around :detekt-gradle-plugin's test code.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #3623 (4f5ae78) into main (6f569c8) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f5ae78 differs from pull request most recent head 5106c78. Consider uploading reports for the commit 5106c78 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3623   +/-   ##
=========================================
  Coverage     78.12%   78.12%           
  Complexity     2837     2837           
=========================================
  Files           467      467           
  Lines          9143     9143           
  Branches       1737     1737           
=========================================
  Hits           7143     7143           
  Misses         1058     1058           
  Partials        942      942           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f569c8...5106c78. Read the comment docs.

@@ -6,13 +6,13 @@ import java.io.File
import java.nio.file.Files
import java.util.UUID

@Suppress("TooManyFunctions")
@Suppress("TooManyFunctions", "ClassOrdering")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add this because of #3559

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 4, 2021
@chao2zhang chao2zhang merged commit 709f879 into main Apr 4, 2021
@chao2zhang chao2zhang deleted the improve-more-tests branch April 4, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants