-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ktlint 0.41.0 #3624
Upgrade to ktlint 0.41.0 #3624
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3624 +/- ##
============================================
- Coverage 78.14% 78.12% -0.02%
- Complexity 2833 2836 +3
============================================
Files 467 467
Lines 9133 9140 +7
Branches 1733 1735 +2
============================================
+ Hits 7137 7141 +4
Misses 1058 1058
- Partials 938 941 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
We now have warnings in our
ImportOrderingRule
like the following:[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value [WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value
We probably need a way to notify our consumers to migrate the values like
idea
orascii
to the recommended regexs.
This is a runtime warnning that our users can see, right? I think that we should just change our default value and that's it. If they have the idea
value in their configuration they will see the warning and they will fix it. And if they don't have it they will use the correct default value.
...formatting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/wrappers/ImportOrdering.kt
Outdated
Show resolved
Hide resolved
...t-test-utils/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/KotlinEnvironmentTestSetup.kt
Show resolved
Hide resolved
...ting/src/main/kotlin/io/gitlab/arturbosch/detekt/formatting/wrappers/ArgumentListWrapping.kt
Show resolved
Hide resolved
Add comments for suppression
Main change in wrapping rules
Formatting fixes
Indentation
rule.Note
We now have warnings in our
ImportOrderingRule
like the following:We probably need a way to notify our consumers to migrate the values like
idea
orascii
to the recommended regexs.