Upgrade to ktlint 0.41.0 - #3624
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3624 +/- ##
============================================
- Coverage 78.14% 78.12% -0.02%
- Complexity 2833 2836 +3
============================================
Files 467 467
Lines 9133 9140 +7
Branches 1733 1735 +2
============================================
+ Hits 7137 7141 +4
Misses 1058 1058
- Partials 938 941 +3
Continue to review full report at Codecov.
|
BraisGabin
left a comment
There was a problem hiding this comment.
Note
We now have warnings in our
ImportOrderingRulelike the following:[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value [WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the valueWe probably need a way to notify our consumers to migrate the values like
ideaorasciito the recommended regexs.
This is a runtime warnning that our users can see, right? I think that we should just change our default value and that's it. If they have the idea value in their configuration they will see the warning and they will fix it. And if they don't have it they will use the correct default value.
Add comments for suppression
Main change in wrapping rules
Formatting fixes
Indentationrule.Note
We now have warnings in our
ImportOrderingRulelike the following:We probably need a way to notify our consumers to migrate the values like
ideaorasciito the recommended regexs.