Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ktlint 0.41.0 #3624

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Upgrade to ktlint 0.41.0 #3624

merged 3 commits into from
Apr 2, 2021

Conversation

chao2zhang
Copy link
Member

Main change in wrapping rules

Formatting fixes

Note

We now have warnings in our ImportOrderingRule like the following:

[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value
[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value

We probably need a way to notify our consumers to migrate the values like idea or ascii to the recommended regexs.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3624 (3d0f885) into main (2dd29ef) will decrease coverage by 0.01%.
The diff coverage is 90.32%.

❗ Current head 3d0f885 differs from pull request most recent head c6ed5e4. Consider uploading reports for the commit c6ed5e4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3624      +/-   ##
============================================
- Coverage     78.14%   78.12%   -0.02%     
- Complexity     2833     2836       +3     
============================================
  Files           467      467              
  Lines          9133     9140       +7     
  Branches       1733     1735       +2     
============================================
+ Hits           7137     7141       +4     
  Misses         1058     1058              
- Partials        938      941       +3     
Impacted Files Coverage Δ Complexity Δ
...etekt/formatting/wrappers/ParameterListWrapping.kt 90.00% <83.33%> (-10.00%) 4.00 <1.00> (ø)
...detekt/formatting/wrappers/ArgumentListWrapping.kt 90.00% <85.71%> (-10.00%) 4.00 <1.00> (+1.00) ⬇️
...lab/arturbosch/detekt/formatting/FormattingRule.kt 95.00% <91.66%> (-2.15%) 15.00 <1.00> (+1.00) ⬇️
...urbosch/detekt/formatting/wrappers/FinalNewline.kt 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <100.00%> (ø) 7.00 <3.00> (ø)
...ch/detekt/formatting/wrappers/MaximumLineLength.kt 90.00% <100.00%> (+2.50%) 6.00 <1.00> (+1.00)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 94.36% <100.00%> (-0.44%) 21.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd29ef...c6ed5e4. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

We now have warnings in our ImportOrderingRule like the following:

[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value
[WARNING] `idea` is deprecated! Please use `*,java.**,javax.**,kotlin.**,^` instead to ensure that the Kotlin IDE plugin recognizes the value

We probably need a way to notify our consumers to migrate the values like idea or ascii to the recommended regexs.

This is a runtime warnning that our users can see, right? I think that we should just change our default value and that's it. If they have the idea value in their configuration they will see the warning and they will fix it. And if they don't have it they will use the correct default value.

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 1, 2021
@chao2zhang chao2zhang merged commit ed1ee8f into detekt:main Apr 2, 2021
@chao2zhang chao2zhang deleted the ktlint branch April 2, 2021 00:31
@cortinico cortinico added the dependencies Pull requests that update a dependency file label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants