Fix tests#3634
Merged
Merged
Conversation
cortinico
approved these changes
Mar 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #3634 +/- ##
============================================
- Coverage 78.25% 78.17% -0.09%
- Complexity 2829 2836 +7
============================================
Files 466 467 +1
Lines 9136 9139 +3
Branches 1724 1733 +9
============================================
- Hits 7149 7144 -5
+ Misses 1059 1057 -2
- Partials 928 938 +10
Continue to review full report at Codecov.
|
schalkms
approved these changes
Mar 30, 2021
Member
|
Thanks for fixing this problem. The merge was unfortunately problematic due to the missing rebase command before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We merged #3545 and #3622 nearly at the same time. They pass, but both at the same time don't. This PR fixes the problem in the test.