Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #3634

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fix tests #3634

merged 1 commit into from
Mar 30, 2021

Conversation

BraisGabin
Copy link
Member

We merged #3545 and #3622 nearly at the same time. They pass, but both at the same time don't. This PR fixes the problem in the test.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3634 (fc561a3) into main (0e680c4) will decrease coverage by 0.08%.
The diff coverage is 53.84%.

❗ Current head fc561a3 differs from pull request most recent head d1e2838. Consider uploading reports for the commit d1e2838 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3634      +/-   ##
============================================
- Coverage     78.25%   78.17%   -0.09%     
- Complexity     2829     2836       +7     
============================================
  Files           466      467       +1     
  Lines          9136     9139       +3     
  Branches       1724     1733       +9     
============================================
- Hits           7149     7144       -5     
+ Misses         1059     1057       -2     
- Partials        928      938      +10     
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 21.42% <0.00%> (ø) 4.00 <0.00> (ø)
...lin/io/gitlab/arturbosch/detekt/rules/TypeUtils.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...t/rules/coroutines/SuspendFunWithFlowReturnType.kt 66.66% <0.00%> (-4.77%) 7.00 <0.00> (ø)
...turbosch/detekt/rules/style/ForbiddenMethodCall.kt 89.18% <0.00%> (-2.71%) 14.00 <0.00> (ø)
.../arturbosch/detekt/rules/style/UseIsNullOrEmpty.kt 58.66% <0.00%> (ø) 40.00 <1.00> (ø)
...otlin/io/github/detekt/custom/SpekTestDiscovery.kt 64.28% <33.33%> (-1.17%) 11.00 <0.00> (ø)
...h/detekt/rules/bugs/DontDowncastCollectionTypes.kt 77.14% <33.33%> (-4.11%) 8.00 <0.00> (ø)
...t/rules/naming/NonBooleanPropertyPrefixedWithIs.kt 82.14% <50.00%> (-3.05%) 12.00 <0.00> (ø)
.../arturbosch/detekt/rules/style/UnnecessaryApply.kt 80.00% <60.00%> (-9.66%) 16.00 <8.00> (+8.00) ⬇️
...les/style/ExplicitCollectionElementAccessMethod.kt 85.18% <71.42%> (-5.14%) 15.00 <5.00> (-1.00)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4228e43...d1e2838. Read the comment docs.

@BraisGabin BraisGabin merged commit e8f03b3 into detekt:main Mar 30, 2021
@BraisGabin BraisGabin deleted the fix-tests branch March 30, 2021 18:55
@schalkms
Copy link
Member

Thanks for fixing this problem. The merge was unfortunately problematic due to the missing rebase command before.

@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants