Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ios tests if no ci #3635

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Skip ios tests if no ci #3635

merged 1 commit into from
Mar 30, 2021

Conversation

BraisGabin
Copy link
Member

This is just a workaround for #3617. @chao2zhang reported the same issue (#3619 (comment)) so I think that we should merge this until we fix the issue properly.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3635 (e5a1167) into main (e8f03b3) will not change coverage.
The diff coverage is n/a.

❗ Current head e5a1167 differs from pull request most recent head b210255. Consider uploading reports for the commit b210255 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3635   +/-   ##
=========================================
  Coverage     78.17%   78.17%           
  Complexity     2836     2836           
=========================================
  Files           467      467           
  Lines          9139     9139           
  Branches       1733     1733           
=========================================
  Hits           7144     7144           
  Misses         1057     1057           
  Partials        938      938           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f03b3...b210255. Read the comment docs.

@BraisGabin BraisGabin force-pushed the skip-ios-tests-if-no-ci branch from bfa3f25 to b210255 Compare March 30, 2021 18:57
@BraisGabin BraisGabin merged commit 3335280 into main Mar 30, 2021
@BraisGabin BraisGabin deleted the skip-ios-tests-if-no-ci branch March 30, 2021 21:24
@cortinico cortinico added this to the 1.17.0 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants