-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noisy gradle #3655
Noisy gradle #3655
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3655 +/- ##
=========================================
Coverage 78.12% 78.12%
Complexity 2837 2837
=========================================
Files 467 467
Lines 9143 9143
Branches 1737 1737
=========================================
Hits 7143 7143
Misses 1058 1058
Partials 942 942
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
(I left a comment but feel free to drop, the DslGradleRunner is a bit messy when I read the code even before this PR)
.writeText("public class ${name}Test {}") | ||
} | ||
|
||
fun DslGradleRunner.createJavaClass(submodule: Submodule, name: String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these extension methods - Do we think it would be better to modularize as:
fun DslGradleRunner.findMainSrcDir()
fun DslGradleRunner.findTestSrcDir()
fun Submodule.findMainSrcDir()
fun Submodule.findTestSrcDir()
and
fun writeJavaFile()
It might be confusing to have createJavaClass()
write to both main and test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree... I think that we should not have a difference between module and submodule. Both hae the same features. This DSL needs a refactor but I'm not sure if it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't implement this:
fun Submodule.findMainSrcDir()
fun Submodule.findTestSrcDir()
Because a Submodule
doesn't have the information about DslGradleRunner
and I need the DslGradleRunner
to get the base path.
I'd vote to merge this and if you think that we should rethinkg the DslGradleRunner
we can open an issue and see how can we refactor it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably just need housekeeping work on DslGradleRunner
This reverts commit 2c4b6fb.
This reverts commit 2c4b6fb.
Fix #3019
The JVM and the Android tasks are sending non-kotlin files as input to the client. This was configured properly in Plain detekt but not in the others. This PR fixes that.
This PR was originally opened here #3648 but I messed up with a merge and it end up closed automatically.