Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for UnnecessaryFilter #3695

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Conversation

t-kameyama
Copy link
Contributor

Fixes #3541

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #3695 (5c9c3c0) into main (20bc74c) will decrease coverage by 0.00%.
The diff coverage is 82.60%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3695      +/-   ##
============================================
- Coverage     78.04%   78.04%   -0.01%     
  Complexity     2883     2883              
============================================
  Files           473      473              
  Lines          9302     9300       -2     
  Branches       1767     1767              
============================================
- Hits           7260     7258       -2     
  Misses         1078     1078              
  Partials        964      964              
Impacted Files Coverage Δ Complexity Δ
...arturbosch/detekt/rules/style/UnnecessaryFilter.kt 78.78% <82.60%> (-1.22%) 14.00 <7.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bc74c...5c9c3c0. Read the comment docs.

@cortinico
Copy link
Member

Can you add a test case similar to the original case reported here #3541 (comment) ?

@cortinico cortinico merged commit f290bf7 into detekt:main Apr 30, 2021
@t-kameyama t-kameyama deleted the issue_3541 branch April 30, 2021 06:56
@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnnecessaryFilter false positive
3 participants