MultilineLambdaItParameter: don't report when lambda has no implicit parameter references#3696
Merged
Merged
Conversation
…parameter references
Codecov Report
@@ Coverage Diff @@
## main #3696 +/- ##
============================================
+ Coverage 78.00% 78.04% +0.04%
- Complexity 2870 2883 +13
============================================
Files 471 473 +2
Lines 9275 9302 +27
Branches 1766 1767 +1
============================================
+ Hits 7235 7260 +25
Misses 1078 1078
- Partials 962 964 +2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Apr 23, 2021
picklebento
approved these changes
Apr 24, 2021
Member
|
Code coverage is reporting test coverage miss on https://app.codecov.io/gh/detekt/detekt/compare/3696/diff#D1L118. What scenario will it take to fail the condition |
Contributor
Author
|
Yes, I fixed the test. 01104e1 |
picklebento
approved these changes
Apr 25, 2021
picklebento
pushed a commit
to picklebento/detekt
that referenced
this pull request
May 13, 2021
… parameter references (detekt#3696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3570