Skip to content

Build & test on Java 16#3698

Merged
3flex merged 3 commits into
mainfrom
java-16
May 21, 2021
Merged

Build & test on Java 16#3698
3flex merged 3 commits into
mainfrom
java-16

Conversation

@3flex

@3flex 3flex commented Apr 23, 2021

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Apr 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3698 (5bb1eff) into main (506c491) will decrease coverage by 4.90%.
The diff coverage is n/a.

❗ Current head 5bb1eff differs from pull request most recent head b654269. Consider uploading reports for the commit b654269 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3698      +/-   ##
============================================
- Coverage     83.58%   78.67%   -4.91%     
+ Complexity     3055     2887     -168     
============================================
  Files           456      473      +17     
  Lines          8916     9309     +393     
  Branches       1752     1704      -48     
============================================
- Hits           7452     7324     -128     
- Misses          541     1080     +539     
+ Partials        923      905      -18     
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/api/ReportingExtension.kt 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...ab/arturbosch/detekt/core/config/AllRulesConfig.kt 44.44% <0.00%> (-22.23%) 4.00% <0.00%> (ø%)
...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt 80.00% <0.00%> (-20.00%) 4.00% <0.00%> (ø%)
...b/arturbosch/detekt/api/internal/ConfigProperty.kt 80.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
.../arturbosch/detekt/formatting/EditorConfigMerge.kt 80.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...in/kotlin/io/gitlab/arturbosch/detekt/api/Issue.kt 75.00% <0.00%> (-12.50%) 4.00% <0.00%> (ø%)
.../io/github/detekt/tooling/dsl/ConfigSpecBuilder.kt 89.47% <0.00%> (-10.53%) 7.00% <0.00%> (ø%)
...bosch/detekt/rules/style/UnnecessaryInheritance.kt 90.90% <0.00%> (-9.10%) 6.00% <0.00%> (ø%)
.../rules/documentation/UndocumentedPublicProperty.kt 80.00% <0.00%> (-8.47%) 24.00% <0.00%> (-4.00%)
...ab/arturbosch/detekt/cli/runners/ConfigExporter.kt 75.00% <0.00%> (-8.34%) 2.00% <0.00%> (ø%)
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a604c4f...b654269. Read the comment docs.

@3flex

This comment has been minimized.

@3flex 3flex added the blocked label Apr 23, 2021
cortinico
cortinico previously approved these changes Apr 26, 2021
@cortinico

Copy link
Copy Markdown
Member

@3flex where you able to understand what are the build failures? It seems we have failing tests plus generateDocumentation is failing

@3flex

3flex commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

I believe it's now blocked thanks to an out of date transitive dependency of mockk and also Android Gradle Plugin incompatibility with Java 16.

Mockk will be fixed soon enough I expect but I can manually add the required dependency version to fix it in the meantime.

I can't find compatibility info for AGP. They probably only officially support the JDK version shipped with Android Studio (currently 11?) So Android tests should probably be skipped on other JDK versions.

I have to check the generateDocumentation task.

@3flex 3flex marked this pull request as draft May 2, 2021 10:16
@3flex 3flex force-pushed the java-16 branch 2 times, most recently from d06d67f to 68798ae Compare May 6, 2021 02:52
@3flex

This comment has been minimized.

@3flex 3flex marked this pull request as ready for review May 6, 2021 12:16
@3flex 3flex added this to the 1.18 milestone May 14, 2021
Comment thread gradle/libs.versions.toml Outdated
Comment thread gradle/libs.versions.toml
@cortinico cortinico dismissed their stale review May 20, 2021 14:49

Waiting for separate Kotlin bump

3flex added 3 commits May 21, 2021 22:53
This transitive dependency of mockk is updated to a version that supports
Java 16
Required until a compatible version of Android Gradle Plugin is released.
@3flex 3flex merged commit 459d467 into main May 21, 2021
@3flex 3flex deleted the java-16 branch May 21, 2021 22:19
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notable changes Marker for notable changes in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants