-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions cache fixes #3723
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3723 +/- ##
============================================
- Coverage 84.27% 84.10% -0.17%
+ Complexity 3249 3197 -52
============================================
Files 471 466 -5
Lines 10261 10089 -172
Branches 1805 1773 -32
============================================
- Hits 8647 8485 -162
- Misses 664 673 +9
+ Partials 950 931 -19
Continue to review full report at Codecov.
|
abb37cf
to
46539b2
Compare
14b671d
to
e599991
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4f1046b
to
690b98a
Compare
Created #4194 with the changes that aren't blocked by gradle-build-action@v2. I still suggest not merging this one until gradle-build-action@v2 stable version is released (they're at beta 6 now so you'd think they're close - I'm subscribed to release notifications on that repo so I'll update here once it's good to go). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for gradle/gradle-build-action@2.0. Just saw that RC1 got released one hour ago.
This action handles caching of: - Wrapper distribution - Downloaded dependencies - Build cache - Configuration cache https://github.com/gradle/gradle-build-action/blob/v2.0.0/README.md#caching
gradle-build-action runs Gradle tasks with --no-daemon flag already
An issue I've experienced with this implementation: gradle/gradle-build-action#120 Hopefully this is caught by the action in future. I don't think it's worth rolling back; it's not typical to have several jobs running concurrently. We might also try only caching on main branch: https://github.com/gradle/gradle-build-action/blob/v2.0.0/README.md#only-write-to-the-cache-from-the-default-branch This would avoid many uploads occurring at once thanks to multiple PRs being opened quickly one after the other, but it would still occur when multiple PRs are merged quickly one after the other on main branch. |
Summary of changes:
Blocked until gradle-build-action v2 goes into production release as the configuration syntax could potentially change.