Remove --stacktrace now that we have scan #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3724 +/- ##
=========================================
Coverage 78.04% 78.04%
Complexity 2883 2883
=========================================
Files 473 473
Lines 9300 9300
Branches 1767 1767
=========================================
Hits 7258 7258
Misses 1078 1078
Partials 964 964 Continue to review full report at Codecov.
|
schalkms
approved these changes
Apr 30, 2021
chao2zhang
reviewed
Apr 30, 2021
| @@ -54,7 +54,7 @@ jobs: | |||
|
|
|||
|
|
|||
| - name: Build detekt | |||
| run: ./gradlew build moveJarForIntegrationTest -x detekt -PwarningsAsErrors=true --stacktrace | |||
| run: ./gradlew build moveJarForIntegrationTest -x detekt | |||
There was a problem hiding this comment.
Do we still want to keep warningAsError? I remember that there was a PR to fix all grande warnings
Merged
chao2zhang
pushed a commit
to chao2zhang/detekt
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #3604 now that we have #3710
--stacktraceis quite noisy and it makes difficult to find which test failed.