Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Multiplatform iOS tests if XCode is not configured #3734

Merged
merged 2 commits into from
May 4, 2021

Conversation

cortinico
Copy link
Member

Fixes #3617

@chao2zhang
Copy link
Member

From the CI result, we probably need to catch IOException if xcode-select is not found.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the CI result, we probably need to catch IOException if xcode-select is not found.

or even better to check whether the host OS is actually a Mac

@cortinico
Copy link
Member Author

From the CI result, we probably need to catch IOException if xcode-select is not found.

or even better to check whether the host OS is actually a Mac

I've included both 👍

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #3734 (719c125) into main (50b453b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3734   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9300     9300           
  Branches       1767     1767           
=========================================
  Hits           7258     7258           
  Misses         1078     1078           
  Partials        964      964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b453b...719c125. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

@schalkms schalkms added this to the 1.17.0 milestone May 4, 2021
@schalkms schalkms merged commit b053a33 into detekt:main May 4, 2021
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label May 5, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
* Skip iOS tests if XCode is not configured

* PR feedbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for multiplatform projects - iOS target fails
4 participants