Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set the org.gradle.dependency.bundling attribute to external" #3750

Merged
merged 1 commit into from
May 7, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 7, 2021

Reverts #3738

See #3743 & #3747. The workaround won't be necessary now we're back to publishing a single variant with the attribute "org.gradle.usage": "java-runtime"

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3750 (ba231a2) into main (61cb0b6) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3750      +/-   ##
============================================
+ Coverage     78.67%   78.70%   +0.02%     
  Complexity     2888     2888              
============================================
  Files           473      473              
  Lines          9309     9306       -3     
  Branches       1704     1704              
============================================
  Hits           7324     7324              
+ Misses         1080     1077       -3     
  Partials        905      905              
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 6.25% <ø> (+0.36%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61cb0b6...ba231a2. Read the comment docs.

@3flex 3flex merged commit a661919 into main May 7, 2021
@3flex 3flex deleted the revert-3738-nc/bundling-external branch May 7, 2021 03:52
@cortinico cortinico added this to the 1.17.0 milestone May 12, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 12, 2021
@cortinico
Copy link
Member

Thanks for taking care of this @3flex 🙏

chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants