Skip to content

Always run warningsAsErrors on CI #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2021
Merged

Always run warningsAsErrors on CI #3754

merged 1 commit into from
May 8, 2021

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented May 8, 2021

Merging #3724 I introduced a regresion disabled what I enabled at #3646

Anywy I found that my previous approuch wasn't good enought because warningsAsErrors mess up with the gradle cache so we want to have a consistent value for warningsAsErrors in all out CI. For this reason I change this in the gradle files instead of adding the flag in the workflows.

(I'm adding a stub commit to ensure that this do what it's meant to do) Done, and it works like a charm.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label May 8, 2021
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #3754 (24c87ae) into main (7cc0c9d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3754      +/-   ##
============================================
+ Coverage     78.73%   78.75%   +0.02%     
- Complexity     2896     2900       +4     
============================================
  Files           473      473              
  Lines          9335     9336       +1     
  Branches       1721     1722       +1     
============================================
+ Hits           7350     7353       +3     
  Misses         1075     1075              
+ Partials        910      908       -2     
Impacted Files Coverage Δ Complexity Δ
.../rules/documentation/UndocumentedPublicProperty.kt 88.46% <0.00%> (+8.46%) 28.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc0c9d...24c87ae. Read the comment docs.

@chao2zhang chao2zhang merged commit 85c89d4 into detekt:main May 8, 2021
@cortinico cortinico added this to the 1.17.0 milestone May 12, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants