Always run warningsAsErrors on CI - #3754
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3754 +/- ##
============================================
+ Coverage 78.73% 78.75% +0.02%
- Complexity 2896 2900 +4
============================================
Files 473 473
Lines 9335 9336 +1
Branches 1721 1722 +1
============================================
+ Hits 7350 7353 +3
Misses 1075 1075
+ Partials 910 908 -2
Continue to review full report at Codecov.
|
schalkms
approved these changes
May 8, 2021
picklebento
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging #3724 I introduced a regresion disabled what I enabled at #3646
Anywy I found that my previous approuch wasn't good enought because
warningsAsErrorsmess up with the gradle cache so we want to have a consistent value forwarningsAsErrorsin all out CI. For this reason I change this in the gradle files instead of adding the flag in the workflows.(I'm adding a stub commit to ensure that this do what it's meant to do)Done, and it works like a charm.